modern-irc icon indicating copy to clipboard operation
modern-irc copied to clipboard

clarify that servers SHOULD send RPL_ENDOFWHOIS

Open slingamn opened this issue 1 year ago • 6 comments

From discussion on https://github.com/Libera-Chat/sable/issues/101

cc @progval

slingamn avatar Oct 08 '24 22:10 slingamn

@spb pointed out that RPL_ENDOFWHOIS is not sent after ERR_NEEDMOREPARAMS

progval avatar Oct 09 '24 06:10 progval

RPL_ENDOFWHOIS is not sent after ERR_NEEDMOREPARAMS

Not after ERR_NONICKNAMEGIVEN either.

tommyrot avatar Oct 09 '24 12:10 tommyrot

At least in our implementation we only send ERR_ENDOFWHOIS after a well formed WHOIS request. So you'll only get it after one ERR_NOSUCHNICK or one or more RPL_WHOIS* numerics. I don't think we need to worry too much about clients sending broken responses imo.

sadiepowell avatar Oct 09 '24 12:10 sadiepowell

Thanks, I updated this to clarify that the SHOULD only applies when the client's message is well-formed.

slingamn avatar Oct 15 '24 02:10 slingamn

Can/should we also keep it a MUST when there is no <target> (ie. local whois), or should we leave this implementation-specific?

progval avatar Oct 15 '24 06:10 progval

I don't see a compelling reason to change it right now (we would presumably have to do a more detailed investigation of server behaviors, also it's not clear to me that a hard guarantee here would be helpful to clients --- as in the debate over labeled-response, clients should probably implement a timeout regardless?)

I would support opening a follow-up thread to discuss this.

slingamn avatar Oct 16 '24 19:10 slingamn

Bump

slingamn avatar Nov 17 '24 20:11 slingamn