modern-irc icon indicating copy to clipboard operation
modern-irc copied to clipboard

Add a paragraph on handling unexpected parameters of numerics.

Open progval opened this issue 3 years ago • 4 comments

progval avatar Dec 24 '21 12:12 progval

Never heard of this, seems made up...

jwheare avatar Dec 24 '21 13:12 jwheare

Well yes, I made it up because from what I noticed.

Examples of numerics extended this way: RPL_TIME, RPL_LOCALUSERS, RPL_GLOBALUSERS, RPL_ADMINME, RPL_WHOISACTUALLY Also, without the human-readable trailing: RPL_TOPICWHOTIME, RPL_BANLIST

progval avatar Dec 24 '21 13:12 progval

I don't think this is a general rule though, "Unless specified otherwise" seems a bit too catch-all, imo this should be specified explicitly on the numerics that do it, because it seems very weird and would likely break a lot of clients.

jwheare avatar Dec 24 '21 13:12 jwheare

This is for future-proofing against servers who will add parameters in the future. eg. this issue with RPL_WHOISCOUNTRY in kiwiirc: https://github.com/kiwiirc/irc-framework/pull/318/commits/e6c761f9b32a66078c9df326736d4221346b8c3f

progval avatar Dec 24 '21 13:12 progval