irccloud-desktop icon indicating copy to clipboard operation
irccloud-desktop copied to clipboard

Multiple dictionary input isn't supported by spellchecker

Open jwheare opened this issue 7 years ago • 10 comments

Reported https://github.com/irccloud/irccloud-desktop/issues/97#issuecomment-350684063

This isn't supported by any of the following:

  • https://github.com/mixmaxhq/electron-spell-check-provider
  • https://github.com/electron-userland/electron-spellchecker
  • https://github.com/electron/electron/blob/master/docs/api/web-frame.md#webframesetspellcheckproviderlanguage-autocorrectword-provider

jwheare avatar Dec 11 '17 13:12 jwheare

Failed experiment with electron-spellchecker here: https://github.com/irccloud/irccloud-desktop/commit/3bb14d3765d987ecf8ad1b0146a037c445ead867

jwheare avatar Dec 11 '17 13:12 jwheare

@jwheare from Multiple dictionary input do you mean that spellchecker should auto-detect and switches to the language user typing in?

akashnimare avatar Jan 05 '18 18:01 akashnimare

See the linked comment. That user has English and German and expects spellings for both languages to be accepted. I believe that's standard macOS behaviour.

jwheare avatar Jan 05 '18 19:01 jwheare

On Linux/Windows, electron-spellchecker can automatically switch to the language user is typing in. This doesn't work on macOS though. Please see.

akashnimare avatar Jan 05 '18 19:01 akashnimare

Good to know, thanks.

jwheare avatar Jan 05 '18 20:01 jwheare

For the time being it would be nice to optionally disable spellcheck? The input lag after a couple of words is quite significant and a bit annoying :/

coffeejunk avatar Jan 13 '18 15:01 coffeejunk

@coffeejunk Edit -> Spelling and Grammar -> Check Spelling While Typing

jwheare avatar Jan 13 '18 16:01 jwheare

Spellcheck when using the app via the Appimage on Fedora Linux doesn't seem to work correctly. Other Electron based applications seem to have the same kinds of problems. Rocket chat seems to have figured it out using a different package https://github.com/RocketChat/Rocket.Chat.Electron/pull/266/files

jdoss avatar Mar 13 '18 04:03 jdoss

@jdoss could you explain what you mean by "work correctly"? If it's unrelated to multiple dictionaries, could you open up a separate issue describing what's wrong with some examples?

jwheare avatar Mar 13 '18 07:03 jwheare

@jwheare sure thing. Here is the new issue that details out the problem: https://github.com/irccloud/irccloud-desktop/issues/116

jdoss avatar Mar 15 '18 00:03 jdoss