Bot gets stuck half-offline

[cmsj]

I seem to have to restart irccat every few days, when logs are getting this error every couple of minutes:

2020/06/08 22:24:12 Error, disconnected: SASL setup timed out. Does the server support SASL?
2020/06/08 22:24:13 Connected to irc.freenode.net:6697 (204.225.96.251:6697)

When it's in this state, it's still receiving events from GitHub, but is unable to relay them to IRC.

[russss]

I think this is probably the same issue as #21? I haven't quite pinned it down yet, but it doesn't happen that often for me.

[cmsj]

Possibly, although I haven’t noticed that same error message.

I was looking at go-ircevent as the possible culprit and found this commit: https://github.com/cpatulea/foubot2/commit/49e7b9576b2cf0363f964a915670549cc591e258 which didn’t make me feel good about being able to fix this quickly!

[cpatulea]

We're still running into this, even after disabling autoreconnect [edit] and adding a manual reconnect loop using irccon.Reconnect() (https://github.com/FOULAB/foubot2/commit/c5e90db13e29fc86d5ccb435b431e9be5ddb5f79):

IRC: 01:36 -!- foubot [~foubot2@foulab/bot/foubot] has quit [Ping timeout: 258 seconds]

syslog:
Oct 19 01:36:51 foubot foubot[20658]: 2023/10/19 01:36:51 Error, disconnected: EOF
Oct 19 01:36:52 foubot foubot[20658]: 2023/10/19 01:36:52 Connected to irc.libera.chat:6697 (64.38.145.232:6697)
Oct 19 01:37:07 foubot foubot[20658]: Connect error: SASL setup timed out. This shouldn't happen.
Oct 19 01:38:07 foubot foubot[20658]: 2023/10/19 01:38:07 Connected to irc.libera.chat:6697 (176.58.122.119:6697)
Oct 19 01:38:22 foubot foubot[20658]: Connect error: SASL setup timed out. This shouldn't happen.
...
Oct 19 18:40:03 foubot foubot[20658]: 2023/10/19 18:40:03 Connected to irc.libera.chat:6697 (94.125.182.252:6697)
Oct 19 18:40:18 foubot foubot[20658]: Connect error: SASL setup timed out. This shouldn't happen.

This time a human noticed a problem and rebooted it.

[cpatulea]

This happened again for us, so there's definitely a bug. I'll take another stab at a workaround next week.