Ivan comments

Repositories
Issues
Comments

Results 23 comments of


                                            Ivan

Fix bug that header values are not null-terminated

Thank you for the PR. Fixing the first issue implies a fix for the second one since utf-16 should be treated as Buffer.

Plugin crashes when pull request has merge conflict

Yes absolutely, that would be much better indication that something is wrong. For example Jenkins has ability to handle test/build errors with special kind of status message (failure or unstable).

Using it behind nginx

To run this tool behind reverse proxy you would have to proxy both HTTP and WebSocket traffic back to the tool. I'm not sure how to do this with Nginx...