explorer icon indicating copy to clipboard operation
explorer copied to clipboard

richlist chart

Open F3nixsec opened this issue 2 years ago • 2 comments

have a error in google chrome console Uncaught ReferenceError: pieWealthDist is not defined at richlist:79:3 at dispatch (jquery.min.js:3:8066) at r.handle (jquery.min.js:3:4767)

and distribution in chart dont work

F3nixsec avatar Apr 15 '22 18:04 F3nixsec

A pull request was added 4 years ago that fixes this error by moving the window resize function into the document.ready scope. For some reason it was closed and never merged into the main source. To be honest, I think an easier fix would be to just remove the whole window resize function altogether because replotting the pie chart on window resize seems to do nothing anyway and is probably unnecessary.

https://github.com/iquidus/explorer/pull/155/files

joeuhren avatar May 25 '22 01:05 joeuhren

Looks like the author of that PR closed it himself. I don't think we have the .resizable parameter set on the pieWealthDist, so I both agree that its probably useless having the variable on the window resize. If we added the resizable, i'd change up the (window).resize and instead just bind it to the event or to the window.onresize and add proper error checking for the variable.

jqPlot is also extremely outdated, and could probably be due for an upgrade to something like chart.js or something else.

uaktags avatar May 26 '22 02:05 uaktags