tmkms icon indicating copy to clipboard operation
tmkms copied to clipboard

split tmkms into multiple, more modular crates.

Open 0xForerunner opened this issue 3 years ago • 2 comments

tmkms has a lot of potentially useful logic baked into it. For my particular use case it would be fantastic to have access to just the cosmos ledger signing logic. I could see this being much more modular and useful to other projects if it were split into 2 or even 3 different crates!

0xForerunner avatar Dec 21 '22 18:12 0xForerunner

We're working on a next-generation KMS with a multi-crate architecture here:

https://github.com/iqlusioninc/iqkms

That said, we are not going to make major architectural changes to TMKMS. It's mission-critical and stable in its current form.

I'm curious to know what parts of the transaction signing logic are still valuable. They all predate the migration to Protobufs. I understand how the Amino JSON parts are still valuable specifically in the context of Ledger signing, but do you still need Amino binary serialization support? It carries a high maintenance burden.

I would suggest factoring whatever parts you find are still valuable for e.g. Ledger signing into CosmRS:

https://github.com/cosmos/cosmos-rust

tony-iqlusion avatar Dec 21 '22 22:12 tony-iqlusion

I didn't know about iqkms actually so that answers my question there. I must have missed that somehow. I'll have to look into that.

but do you still need Amino binary serialization support?

To be honest at this point I'm not entirely certain what my requirement are. I'm still yet to have success with getting a ledger signature to be properly validated.

0xForerunner avatar Dec 21 '22 22:12 0xForerunner