ipykernel icon indicating copy to clipboard operation
ipykernel copied to clipboard
verified publisher icon ipython

Drop Tornado

Open davidbrochart opened this issue 3 years ago • 4 comments

Closes #656

davidbrochart avatar Feb 23 '22 19:02 davidbrochart

Thanks @davidbrochart for this. I got a question and a comment.

Thanks for the review @fcollonval. This is still a WIP so I'll make this PR a draft. I can see that the kernel is functional e.g. in JupyterLab, but there are still some issues, at least with shutdown.

davidbrochart avatar Feb 24 '22 13:02 davidbrochart

Although ipykernel seems functional with these changes, I don't really understand the test failures. I think the next step is getting rid of the ZMQStream with their on_recv callbacks (which were really specific to Tornado), and just have tasks that receive messages and handle them. I would also like to get rid of the jupyter_client dependency. It seems weird for a "server" to depend on a "client".

davidbrochart avatar Mar 11 '22 09:03 davidbrochart

I would also like to get rid of the jupyter_client dependency

I wouldn't do that. jupyter-protocol would have been a better name for that repo, since that's really what it defines. It is meant to be a dependency for any Python use of the Jupyter protocol, and that includes ipykernel.

minrk avatar Mar 11 '22 19:03 minrk

I think the next step is getting rid of the ZMQStream with their on_recv callbacks

👍

a simpler while True: poll/recv/process/send coroutine ought to work, and might even make channel priority easier to ensure.

minrk avatar Mar 11 '22 19:03 minrk

Closing in favor of #1079.

davidbrochart avatar Jan 25 '23 09:01 davidbrochart