go-car

go-car copied to clipboard

go-car/v2 offers an API to [replace root CIDs](https://github.com/ipld/go-car/blob/f4378127a67f1bf4d616ef83a1e5a4d841a9478b/v2/writer.go#L222) in the inner CARv1 as long as the replacement does not change the size of inner CARv1 header. This is to provide...

masih

It should be straight-forward to take a car, and ask for it to be streamed out in depth-first selector traversal order from the root. This mode should: * warn if...

willscott

it may be possible for a malformed car to specify a symlink, and then later in the same directory specify another entry with the same name, that could then be...

willscott

v2: use a byte array for the characteristics bitfield

1

Right now, characteristics is [as follows](https://pkg.go.dev/github.com/ipld/go-car/[email protected]#Characteristics): ``` type Characteristics struct { Hi uint64 Lo uint64 } ``` And, as per the code, it encodes and decodes as little-endian. If Go...

mvdan

`ReadOrGenerateIndex` does not re-generate index if the existing index doesn't satisfy passed options. https://github.com/ipld/go-car/blob/f4378127a67f1bf4d616ef83a1e5a4d841a9478b/v2/index_gen.go#L146-L149

masih

blockstore: OpenReadOnly shouldn't need to parse the entire index into memory in some cases

1

Right now we always read and unmarshal an existing whole index into memory. Luckily, IndexSorted is designed to allow using directly as a mmapped []byte from disk. If OpenReadOnly is...

mvdan

Make CAR v2 index iterable without having to read it all into memory

1

Ideally, the index would not have to be loaded into memory to be iterated, like [this](https://github.com/filecoin-project/dagstore/pull/2/files#diff-b0929dacd4f1fc192cd308c1a9db2e85154ea742ccec315518e659d7f6a3efc7R347). See: * https://github.com/filecoin-project/dagstore/pull/2#discussion_r656358001

masih

Use consistent terminology to refer to a section in CAR file

3

The term "Section"[ is used](https://ipld.io/specs/transport/car/carv1/#format-description) to describe the repeated `` format that collectively make up the Data portion of a CAR file. Use terminology consistent with docs in code to...

masih

Indexes don't take advantage of performant structure

3

The common form of [Index](https://github.com/ipld/go-car/blob/3c99491a50b5a4adfbb187b4dba07bb6b37fbb7d/v2/index/index.go#L57) introduced in Car V2 is to lay out the CIDs in the car in a sorted table that can be quickly walked through with a...

willscott

carv2.NewBlockReader cannot be used with a stream

1

`NewBlockReader` takes an `io.Reader`, however when passed `os.Stdin` with a carv2 payload, the call to new will error with "seek /dev/stdin: illegal seek" It's unclear how this is trying to...

willscott