public-gateway-checker icon indicating copy to clipboard operation
public-gateway-checker copied to clipboard

Abstract and encapsulate gateway checking logic from this package and JayBrown/Tools/tree/master/ipfg

Open SgtPooki opened this issue 4 years ago • 3 comments

In the readme, we state:

A CLI version ipfg is available here: https://github.com/JayBrown/Tools/tree/master/ipfg

I propose we encapsulate the logic in this repo into its own encapsulated logic so that one could run the check in both the browser and via CLI, but also via other packages.

It would also make sense to support the often requested "gateway race" logic within this package.

SgtPooki avatar Mar 02 '22 00:03 SgtPooki

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

welcome[bot] avatar Mar 02 '22 00:03 welcome[bot]

@lidel thoughts?

SgtPooki avatar Mar 02 '22 00:03 SgtPooki

SGTM.

I will be writing HTTP Gateway specs, and want to have a compliance test suite for HTTP gateway that tests against that spec.

Some tests are really easy to do outside of browser, so I am not sure if we will have 100% code resuse, but even if we could have 80% of code that can run in both browser and CI that is a big win.

First step would be to extract logic and run tests on GithubAction CI, testing PRs submitted against this repo and failing if gateway is offline or does not support IPNS.

lidel avatar Apr 04 '22 23:04 lidel