kubo icon indicating copy to clipboard operation
kubo copied to clipboard

chore: update go-libp2p-kad-dht

Open Jorropo opened this issue 2 years ago • 3 comments

Depends on:

  • https://github.com/libp2p/go-libp2p-kad-dht/pull/873
  • https://github.com/libp2p/go-libp2p-kad-dht/pull/872
  • https://github.com/libp2p/go-libp2p-routing-helpers/pull/80

Jorropo avatar Aug 25 '23 08:08 Jorropo

I this PR superseded by https://github.com/ipfs/kubo/pull/10116?

dennis-tra avatar Sep 18 '23 09:09 dennis-tra

2023-11-09 maintainer conversation:

  • High level: we either need to be able to update or we revert the breaking changes in go-libp2p-kad-dht
  • We can't test WAN mode in the CI tests.
  • Going to make test setup / configuration to see if can get tests to pass.
  • Need to backlog the "better way" of handling. @Jorropo will write this.

BigLep avatar Nov 09 '23 15:11 BigLep

2024-01-04 maintainer conversation:

  • We don't know why 0.25 broke. We need to start here. Once we understand (and document) this, we will then figure out how we respond. (Getting understanding is the minimum requirement for 202401 Mercury).

BigLep avatar Jan 04 '24 16:01 BigLep

go-libp2p-kad-dht v0.25.2 shouldn't be broken. However v0.25.0 introduced a change to prevent private addresses to land on the public Amino DHT, so some tests may need to be modified.

The following fix can be applied to tests failing because test nodes are using loopback/private addresses https://github.com/libp2p/go-libp2p-kad-dht/pull/839#issuecomment-1673690007

Reference: https://github.com/libp2p/go-libp2p-kad-dht/blob/088322b3bd36f384963225348a23f5723a2b80c3/dual/dual.go#L98-L127

guillaumemichel avatar Mar 08 '24 11:03 guillaumemichel