js-ipfsd-ctl icon indicating copy to clipboard operation
js-ipfsd-ctl copied to clipboard
verified publisher icon ipfs

Proper error propagation

Open poolsar42 opened this issue 3 years ago • 1 comments

Hello Everyone,

It's a simple (I hope) issue to fix: Proper error throwing and handling when config object in ipfsOptions isn't right.

Today I was trying to set a constructor, and used following: ipfsOptions: { config: { Datastore: { StorageMax: '35GB', StorageGCWatermark: '99', }, }, } Here, you can see I was trying to set StorageGCWatermark to a string. But it has to be int. But instead of throwing an error it wasn't do anything. It was just ignoring config options and it was frustrating,

Thanks <3

poolsar42 avatar Mar 29 '22 06:03 poolsar42

Huh, I think this issue is duplicate from a previous one

I'll keep it just in case

poolsar42 avatar Mar 29 '22 06:03 poolsar42

@poolsar42 this should be resolved with the merging of https://github.com/ipfs/js-ipfsd-ctl/pull/722. Can you confirm that this issue is resolved for you?

SgtPooki avatar Oct 19 '22 01:10 SgtPooki

@SgtPooki nice! Let's close this issue for now, I'll open new one if something wrong

poolsar42 avatar Oct 21 '22 15:10 poolsar42