js-ipfs
js-ipfs copied to clipboard
feat: encoding key's name to base32
This PR tackles #1937. Yet I am not so sure if it is actually needed.
Since how Keystore works (eq. has stored metadata in /info
), it could be easier to just lowercase the filenames instead of encoding them into base32. Yet, if there is a desire to have the same IPFS Repo like with go
then this will be needed. Although I guess it should be actually go
who should adopt the same pattern for Keystore as is in js
(eq. encrypt keys with a passphrase and have metadata aside). Not sure if it is in plan in the near future, though.
Blocking PRs:
- [ ] integration of migration tool https://github.com/ipfs/js-ipfs-repo/pull/202
- [ ] migration for encoding existing keys https://github.com/ipfs/js-ipfs-repo-migrations/pull/2
Hi! js-ipfs master just got a whole new set of automated tests with #2528, https://github.com/ipfs/js-ipfs/pull/2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you!
Is this actually in progress?
Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can https://github.com/ipfs/js-ipfs/issues/4336 and read the migration guide.
I don't think this is required any more since Kubo adopted Badger and broke repo compatibility, js-IPFS is free to do what it wants.