ipfs-webui
ipfs-webui copied to clipboard
fixed all eslint warnings in root
#2377
Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:
-
The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.
-
Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:
-
A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.
-
The PR gets reviews, discussed and approvals as needed.
-
The PR is merged by maintainers when it has been approved and comments addressed.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!
@SgtPooki any chance you could provide feedback or a review?
Thanks for running CI, I did not expect to find new warnings. Fixing newly found errors.
Excuse me for being annoying @SgtPooki. I have run npm run lint typecheck and dep-check locally pass.
Excuse me for being annoying @SgtPooki. I have run
npm run linttypecheck and dep-check locally pass.
🤣 no worries, thanks for opening an issue and submitting a fix for it! not a problem at all.. clicking "run CI jobs" is the easiest thing I've done today 😛
:tada: This PR is included in version 4.8.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket: