ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

fixed all eslint warnings in root

Open Pfed-prog opened this issue 6 months ago • 5 comments

#2377

Pfed-prog avatar May 28 '25 04:05 Pfed-prog

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar May 28 '25 04:05 welcome[bot]

@SgtPooki any chance you could provide feedback or a review?

Pfed-prog avatar Jun 04 '25 13:06 Pfed-prog

Thanks for running CI, I did not expect to find new warnings. Fixing newly found errors.

Pfed-prog avatar Jun 04 '25 16:06 Pfed-prog

Excuse me for being annoying @SgtPooki. I have run npm run lint typecheck and dep-check locally pass.

Pfed-prog avatar Jun 04 '25 16:06 Pfed-prog

Excuse me for being annoying @SgtPooki. I have run npm run lint typecheck and dep-check locally pass.

🤣 no worries, thanks for opening an issue and submitting a fix for it! not a problem at all.. clicking "run CI jobs" is the easiest thing I've done today 😛

SgtPooki avatar Jun 04 '25 16:06 SgtPooki

:tada: This PR is included in version 4.8.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

ipfs-gui-bot avatar Aug 07 '25 23:08 ipfs-gui-bot