ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

feat: Add success notification on "set pinning" action

Open SgtPooki opened this issue 2 years ago • 2 comments

Currently, when we attempt to set pinning for a file, it will display a failure notification on failure, but we don't get any obvious feedback when the operation succeeds.

Example:

Currently, when I pin a file using a custom pinning provider (estuary) it succeeds, and the pin.status is "queued" but there is no visual indicator for this scenario. There are a few things going on here:

  1. We need a success notification
  2. We have a bug when displaying and handling "queued" pins

related to https://github.com/ipfs/ipfs-webui/pull/1919

SgtPooki avatar Jul 19 '22 17:07 SgtPooki

Hey @SgtPooki is something like this what you had in mind (with a valid reason ofc)?

image

Do you want a single message for pin/unpin events or would you prefer separate messages (ex successfully pinned / successfully unpinned).

xrazis avatar Aug 31 '22 09:08 xrazis

@xrazis Yea that's what I had in mind. I think a separate message for pinned/unpinned would be ideal, but if that's much more work than we can stick with a singular message for now

SgtPooki avatar Sep 23 '22 19:09 SgtPooki