ipfs-webui icon indicating copy to clipboard operation
ipfs-webui copied to clipboard

UX Bug: Add folder action is hidden behind "import" dropdown button

Open SgtPooki opened this issue 3 years ago • 6 comments

Describe the bug "New folder" behind "Import" doesn't make sense. You can't import something that doesn't exist yet, but you can create it. "Add" instead of "Import" makes the most sense for all of the cases.

To Reproduce Steps to reproduce the behavior:

  1. Go to Files screen
  2. Click on 'Import'
  3. Notice that 'New Folder' is listed as an option under "Import"

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Desktop (please complete the following information): IPFS Desktop on macOS Monterey 12.4 (21F79)

UI v2.15.0 Revision fadd900 See the code Report a bug

Additional context N/A

SgtPooki avatar Jun 20 '22 20:06 SgtPooki

@juliaxbow, we discussed this in our GUI triage meeting, and @lidel mentioned that "Import" was added in the past because it made the most sense for all of the options other than "New Folder". What do you think makes the most sense for this screen?

SgtPooki avatar Jul 07 '22 15:07 SgtPooki

@SgtPooki I'd recommend switching over to "Add," as suggested, or "New," which you'll see on some other file sharing platforms. I'm leaning towards "New" but defer to you on current user flow. Let me know if you want me to conduct some quick tests.

I would also recommend:

  • Modifying icons slightly to show upload vs new folder creation
  • Rename actions for clarity (e.g. "File Upload" or "File Import" vs "File")
  • Adding a line to differentiate between actions (upload vs create)

Screenshot attached for reference. Import Dropdown

juliaxbow avatar Jul 07 '22 22:07 juliaxbow

@lidel what do you think about the proposals from Julia?

SgtPooki avatar Jul 18 '22 17:07 SgtPooki

I think both are :+1: thank you, @juliaxbow!

  • We were avoiding "Upload" in the past (https://github.com/ipfs/ipfs-webui/issues/1951#issuecomment-1209834082) but I am not sure if that rationale still holds up.
  • We may want to go with "New" (V1) as it does not introduce "Upload"
  • OR go with "Add" (V2) but rename "IPFS Upload" to "IPFS Import" (there is no upload in this one)
  • Icon sources are at https://github.com/ipfs-shipyard/ipfs-css#icons - adding new variants is nice to have.

lidel avatar Aug 09 '22 20:08 lidel

Ok so next steps:

  1. change button to "Add"
  2. Change items to "File Import", "Folder Import", "IPFS Import", and "New Folder"
  3. Ensure any icons we use are in https://github.com/ipfs-shipyard/ipfs-css#icons

SgtPooki avatar Oct 07 '22 18:10 SgtPooki

Added the new icons under doc_text_import and folder_import !

juliaxbow avatar Oct 07 '22 18:10 juliaxbow