ipfs-webui
ipfs-webui copied to clipboard
Renaming file will override existing one without warning
Describe the bug
When you rename
a file to match a file that already exists with that name, it overrides the later without any warning.
To Reproduce Steps to reproduce the behavior:
- Go to files page
- Have 2 files:
1.png
and2.png
- Rename
2.png
to1.png
- No warning that original
1.png
will be permanently lost with the rename
Expected behavior @jessicaschilling thoughts on the expected behavior? Maybe open a modal that requires confirmation before actually replacing file?
@rafaelramalho19 Modal to confirm overwrite would be totally consistent; good call. I'll mock something up in the next day or so if that's OK for you 😊
Related is https://github.com/ipfs-shipyard/ipfs-webui/issues/1612 for overwrite on file drag -- we can probably use the same modal in both places.
@rafaelramalho19 -- how about this?
- Icon is
stroke_attention
- Headline is
Overwrite file?
- Text is
You already have a file named (funny-cat.gif) in this directory. Are you sure you want to overwrite it? This action is permanent and cannot be reversed.
- Buttons are
Overwrite
andCancel
NB: Latest mockup of this is at https://github.com/ipfs-shipyard/ipfs-webui/issues/1612#issuecomment-709605768 for feedback.
closing in favor of https://github.com/ipfs/ipfs-webui/issues/1612