ipfs-desktop icon indicating copy to clipboard operation
ipfs-desktop copied to clipboard

`Activate` functions incorrect use

Open Pfed-prog opened this issue 5 months ago • 4 comments

Describe the bug Incorrect usage of activate functions across the repository

To Reproduce Steps to reproduce the behavior:

For example: src\auto-launch.js

Image

Also in other files:

src\automatic-gc.js src\utils\setup-global-shortcut.js

Expected behavior In file src\enable-namesys-pubsub.js no update needed

Pfed-prog avatar Jul 13 '25 18:07 Pfed-prog

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We are triaging issues on weekly basis and aim to give initial feedback within a few business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.tech if you just need general support.

welcome[bot] avatar Jul 13 '25 18:07 welcome[bot]

Thank you for reporting, but what is the bug? Is this just missing TS types?

PR welcome (but please only change things related to this issue.

lidel avatar Jul 17 '25 12:07 lidel

Thank you for reporting, but what is the bug? Is this just missing TS types?

PR welcome (but please only change things related to this issue.

The issue is with not passing enough parameters to the function which is named activate

Pfed-prog avatar Jul 18 '25 01:07 Pfed-prog

Oops, seems like we needed more information for this issue, please comment with more details or this issue will be closed in 7 days.

github-actions[bot] avatar Jul 25 '25 00:07 github-actions[bot]