ipfs-desktop icon indicating copy to clipboard operation
ipfs-desktop copied to clipboard

Integrated aegir as lint

Open Pfed-prog opened this issue 6 months ago • 4 comments

Following up on https://github.com/ipfs/ipfs-desktop/pull/2959

Pfed-prog avatar Jun 12 '25 20:06 Pfed-prog

Fixing error type by wrapping in String() image

image

Pfed-prog avatar Jun 22 '25 06:06 Pfed-prog

removing enableRemoteModule from BrowserWindow Electron module

last mentions in the docs: https://www.electronjs.org/blog/electron-10-0#breaking-changes

Why? https://www.electronjs.org/docs/latest/breaking-changes#default-changed-enableremotemodule-defaults-to-false

We recommend moving away from the remote module.

And figured out how to access a height and width property by following docs https://www.electronjs.org/docs/latest/api/structures/display

Pfed-prog avatar Jun 22 '25 06:06 Pfed-prog

Further Updating getUserMedia https://developer.mozilla.org/en-US/docs/Web/API/MediaDevices/getUserMedia outdated API for getting media streams from the user's device. The mandatory object and properties like chromeMediaSource are specific to older implementations and may not be compatible with modern browsers.

Pfed-prog avatar Jun 22 '25 06:06 Pfed-prog

Makes a lot of sense

I do believe that aegir related lint improvements could be discarded

But I have created smaller prs based on this large pr

Pfed-prog avatar Jul 25 '25 16:07 Pfed-prog