Uninstall don't delete %AppData%

[RubenKelevra]

• OS: Windows
• Version of IPFS Desktop 0.16.0

Describe the bug The following folders are created by IPFS-Desktop while it's being used by the user:

%AppData%\Roaming\IPFS Desktop %USERPROFILE%\.ipfs %USERPROFILE%\.ipfs-desktop

None of which will be removed when IPFS-Desktop will be uninstalled.

Following the principle of the least surprise this should be the case, as this is the warn message Windows shows when uninstalling an application:

To Reproduce Steps to reproduce the behavior:

1. Use IPFS Desktop
2. Uninstall it via the Settings -> Apps
3. Complete the uninstall procedure
4. Look at the quoted paths, which still exist

Expected behavior All data associated with IPFS Desktop should be removed when uninstalling.

[lidel]

• :broken_heart: removal of user data (IPFS_PATH, aka .ipfs) as the default is a bit controversial: we would not do this unless we have a separate, explicit opt-in from the user. Does not seem to be doable with electron-builder tho.

• :green_heart: :question: removal of %AppData% (as long it does not include .ipfs) sounds sensible

  • I think flipping deleteAppDataOnUninstall in electron-builder.yml would do the trick, but actual behavior needs to be verified by someone using MS Windows – PR welcome!

[RubenKelevra]

Some programs do ask for "settings and config files" or something like this on uninstallation. But to be honest the default is to expect that everything will be gone after deinstallation.

Since there are no "files and folders" somewhere for the users to see the default expectation is, that everything stored "within" the program should be gone as well on deinstallation.

[RubenKelevra]

• I think flipping deleteAppDataOnUninstall in electron-builder.yml would do the trick, but actual behavior needs to be verified by someone using MS Windows – PR welcome!

This would lead to the result I am proposing when this solution is implemented:

https://github.com/ipfs/ipfs-desktop/issues/1656#issuecomment-873005235

So the data stored in ipfs would then be gone as well.