ipfs-desktop icon indicating copy to clipboard operation
ipfs-desktop copied to clipboard

bug: OS-level protocol handler (Ubuntu/Windows): opens the app but does nothing

Open ghost opened this issue 5 years ago • 9 comments

  • OS: Linux (Ubuntu 20.04)
  • Version of IPFS Desktop [e.g. 0.11.1] 1b58b62 Describe the bug Using the dweb/ipfs link from https://winworldpc.com/download/4112c2a0-7118-c39a-11c3-a4e284a2c3a5 doesn't have any effect or feedback from the IPFS desktop app.

(They're also hiding the IPFS link with Javascript, but that's a different problem)

To Reproduce Steps to reproduce the behavior: Open dweb://ipfs/QmSDPa5pfSNCxnKv2ybFio2oKvndX6hCbtmg7NNbNhraHe/BeOS%205.0%20Professional.7z in Firefox after installing the ipfs-desktop client via dpkg image Click on 'Open Link'

App opens but there's no feedback image

Expected behavior Some kind of feedback: "File added", "File unavailable", whatever.

** Sidenote **

Your template here says this:

ATTACH LOGS

If possible:
1. Go to `Advanced` → `Open Logs Directory`
2. Find `*.log` files
3. Attach `error.log` and `combined.log` to this issue.

But there doesn't seem to be an 'Advanced' anywhere in the UI.

ghost avatar Jun 14 '20 04:06 ghost

@lidel @rafaelramalho19 or @olizilla -- might you be able to triage? Thank you!

jessicaschilling avatar Jul 01 '20 16:07 jessicaschilling

@voltagex thanks for this detailed report! I'll take a look. Thanks for the note about the issue template too. The advanced menu is only accessible on linux flavours that show a dock / task bar icon like thing. We need a solution for that too, see #1153

olizilla avatar Jul 01 '20 18:07 olizilla

@voltagex is this still a problem on Ubuntu after you update to v0.13.2?

lidel avatar Oct 12 '20 19:10 lidel

Will spin up a VM and test tonight.

On Tue, 13 Oct 2020, at 06:37, Marcin Rataj wrote:

@voltagex https://github.com/voltagex is this still a problem on Ubuntu after you update to v0.13.2 https://github.com/ipfs-shipyard/ipfs-desktop/releases/tag/v0.13.2?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ipfs-shipyard/ipfs-desktop/issues/1549#issuecomment-707308226, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG6T3DK7YV2QQDDZ5INO3SKNLHXANCNFSM4N5JBNGQ.

ghost avatar Oct 12 '20 23:10 ghost

Getting back to this - yes, there's still no indication that anything happened with the link on v0.13.2.

ghost avatar Oct 15 '20 04:10 ghost

@lidel I can also reproduce this on Windows. After installing the desktop app and using the dweb link I originally posted, I get this: image

It's not easy for me to take an Ubuntu screenshot, but it's not blank there (still no feedback though)

ghost avatar Oct 15 '20 04:10 ghost

Thank you @voltagex! This is very useful.

We will prioritize fix for this, could be done as a part of https://github.com/ipfs-shipyard/ipfs-desktop/issues/1646

lidel avatar Oct 15 '20 11:10 lidel

An update on this: I will work on #1646 and then debug this on a Linux and Windows VM. It seems to be working well on macOS. If anyone is having issues on macOS too, please let me know.

hacdias avatar Jan 28 '22 15:01 hacdias

i just tested this by visiting the following URLs in safari on macOS, and while I get the prompt to open in ipfs-desktop, I do not see anything happen in IPFS desktop:

  • dweb://ipfs/QmdmQXB2mzChmMeKY47C43LxUdg1NDJ5MWcKMKxDu7RgQm
  • dweb://ipfs/QmSDPa5pfSNCxnKv2ybFio2oKvndX6hCbtmg7NNbNhraHe/BeOS%205.0%20Professional.7z
  • dweb://ipfs/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D
  • dweb://ipfs/QmQi7RK4b7GckY56yKWUmR5ET4fq7z6ppRZ1nXbKN9P9Ss?filename=Asset%202.png -- have locally

SgtPooki avatar Jul 03 '23 23:07 SgtPooki