ipfs-companion icon indicating copy to clipboard operation
ipfs-companion copied to clipboard

Disabling on specific host should reload page from HTTPS

Open lidel opened this issue 5 years ago • 0 comments

Filling from mobile so we don't forget. Good first issue if someone wants to fix this via a PR before I get to it next week.

Right now, when IPFS integrations are disabled via a toggle, extension assumes http://.

Most servers redirect http://https://, or have HSTS set up, but Companion should default to https://, because if someone did not set up redirect to a secure context, there is a risk of the same website being loaded from http.

Easy fix is to use https:// in the line below:

https://github.com/ipfs-shipyard/ipfs-companion/blob/06227a244d357e2969b52f01dda8ee13df286446/add-on/src/popup/browser-action/store.js#L196

lidel avatar Apr 09 '20 21:04 lidel