ipfs-companion icon indicating copy to clipboard operation
ipfs-companion copied to clipboard

"Copy shareable link" is broken for non-ICANN names

Open lidel opened this issue 3 years ago • 0 comments

Problem

  1. Open https://dweb.link/ipns/blog.almonit.eth
  2. Try to "Copy shareable link"
  3. Clipboard value is "https://blog.almonit.eth"

The .eth is non-ICANN name, which means it is not safe for sharing with third-party people.

Solution

  • The case above should copy https://dweb.link/ipns/blog.almonit.eth
  • Caveat: we should not special-case .eth, .crypto or any other specific TLD, as user should be able to use their own gateway with custom DoH resolvers that support arbitrary naming systems.
    • :point_right: Companion should ship with a list of ICANN TLDs, and for everything else copy subdomain gateway link

lidel avatar Feb 23 '22 18:02 lidel