go-ipfs-cmds icon indicating copy to clipboard operation
go-ipfs-cmds copied to clipboard

Published 20 hours ago • verified publisher icon ipfs

http tests fail with recent versions of github.com/rs/cors

Open keks opened this issue 6 years ago • 1 comments

Namely, when using https://github.com/rs/cors/commit/8dd4211afb5d08dbb39a533b9bb9e4b486351df6 or later.

keks avatar Apr 20 '18 11:04 keks

@lgierth I think you know most about what HTTP headers to expect.

When configured to accept all origins, old versions of rs/cors send an AllowOrigin: <sent Origin> header. New versions will send AllowOrigin: *. Should I change the tests to accept both the supplied Origin and * when configured to accept all origins, or do we need to fix something in the code? CORS, like most web "technology", is still bat country to me... :bat:

keks avatar Apr 23 '18 14:04 keks