go-bitswap icon indicating copy to clipboard operation
go-bitswap copied to clipboard
verified publisher icon ipfs

Don't decrease split on unique message

Open Stebalien opened this issue 6 years ago • 1 comments

We should decrease the split when we fail to receive a message. Otherwise, we'll get a minimum of 50% duplicate blocks if everyone has every block.

Stebalien avatar May 10 '19 07:05 Stebalien

As far as I can tell, not receiving a message causes us to broadcast the request, receive a bunch of duplicate blocks, and then increase the split. This seems backwards.

Stebalien avatar May 10 '19 07:05 Stebalien