distributions icon indicating copy to clipboard operation
distributions copied to clipboard

fix(release): assure new release version is greater than the current one

Open AlexxNica opened this issue 3 years ago • 9 comments

After reviews and comments, we've decided to change the way of handling version checks. With that, here's an updated list of tasks to get this PR going:

  • [ ] Update README.md to reflect the updated way of releasing versions (if any changes have been made to commands or other references).
  • [ ] Add the new packages to package.json and lock them into a specific major version (also update the package-lock.json).
    • Package suggestions:
      • https://github.com/npm/node-semver
      • https://github.com/release-it/release-it
  • [ ] Add tests to ensure the version check is working the way it should be.

Fixes #319

AlexxNica avatar Jul 30 '21 00:07 AlexxNica

Thank you for submitting this PR! A maintainer will be here shortly to review it. We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the rest) and in its best form. Follow the code contribution guidelines if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment. Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on any missing things and potentially assigning a reviewer for high priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. We are very grateful for your contribution!

welcome[bot] avatar Jul 30 '21 00:07 welcome[bot]

@AlexxNica: are you able to incorporate comments so we an get this merged?

BigLep avatar Mar 10 '22 09:03 BigLep

@AlexxNica: are you able to incorporate comments so we an get this merged?

@BigLep absolutely! Will get that done ASAP.

AlexxNica avatar Mar 11 '22 01:03 AlexxNica

Awesome. Please set the status to "In Review" when it's ready to be looked at again. Thanks!

BigLep avatar Mar 11 '22 05:03 BigLep

@AlexxNica : just checking in. Are you able to incorporate comments?

BigLep avatar Mar 25 '22 04:03 BigLep

@BigLep

Sorry for the delay!

I'd suggest we integrate any reliable package from npm that already handles everything SemVer-related and call it from the bash script to validate versions.

I couldn't easily find a ready-to-use and reliable way of checking and comparing SemVer versions directly within bash, so migrating to a node script of some sort would be the best option unless we have the need to keep this logic within a bash script.

AlexxNica avatar Apr 26 '22 21:04 AlexxNica

@AlexxNica : I agree that it doesn't seem like a good idea to implementing this kind of thing in Bash - ugh. I dont' have experience with this repo, but if there's an npm package you have in mind for pulling in, feel free to do so. Thanks.

BigLep avatar Apr 27 '22 07:04 BigLep

@BigLep, Yea, implementing that in Bash is not a pretty thing.. 😰

As for the npm package, I'd use the battle-tested package used by node itself: https://github.com/npm/node-semver.

I'll put this in my backlog and try getting it done within the next two weeks.

AlexxNica avatar Apr 27 '22 07:04 AlexxNica

Update: having to push this to probably the end of the month due to a project launch we'll have between this and next week.

In the meantime, I've updated the PR description with a new checklist of to-dos.

cc @BigLep

AlexxNica avatar May 16 '22 19:05 AlexxNica