boxo icon indicating copy to clipboard operation
boxo copied to clipboard

[ipfs/go-bitswap] Check wantlists by multihash

Open Winterhuman opened this issue 3 years ago • 3 comments

As mentioned at https://github.com/ipfs/boxo/issues/420, Bitswap apparently still checks wantlists by CID instead of multihash

Winterhuman avatar Sep 15 '22 10:09 Winterhuman

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

welcome[bot] avatar Sep 15 '22 10:09 welcome[bot]

Sounds reasonable. When we pick this up, make sure specs are up-to-date https://github.com/ipfs/specs/blob/main/BITSWAP.md#bitswap-110

guseggert avatar Sep 15 '22 15:09 guseggert

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review. In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment. Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

welcome[bot] avatar Jan 27 '23 22:01 welcome[bot]

Continued in https://github.com/ipfs/boxo/issues/420

lidel avatar Aug 01 '24 15:08 lidel