boxo icon indicating copy to clipboard operation
boxo copied to clipboard

bitswap client does not need ProviderQueryManager

Open gammazero opened this issue 1 year ago • 1 comments

The bitswap Client does not to hold a reference to the ProviderQueryManager. The session maintains the ProviderQueryManager reference.

gammazero avatar Sep 30 '24 21:09 gammazero

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.32%. Comparing base (7bf89a7) to head (2143247). Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
+ Coverage   60.30%   60.32%   +0.02%     
==========================================
  Files         243      243              
  Lines       31019    31018       -1     
==========================================
+ Hits        18705    18711       +6     
+ Misses      10649    10643       -6     
+ Partials     1665     1664       -1     
Files with missing lines Coverage Δ
bitswap/client/client.go 90.00% <100.00%> (+1.87%) :arrow_up:

... and 8 files with indirect coverage changes

codecov[bot] avatar Sep 30 '24 22:09 codecov[bot]