boxo icon indicating copy to clipboard operation
boxo copied to clipboard

blockservice: remove inner fields access methods

Open Jorropo opened this issue 2 years ago • 2 comments

I'll do changelog once we decide on an option.

Jorropo avatar Jan 15 '24 12:01 Jorropo

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Jorropo avatar Jan 15 '24 12:01 Jorropo

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a76d47d) 65.45% compared to head (783f4ca) 65.40%.

Impacted file tree graph

@@                                          Coverage Diff                                          @@
##           01-15-blockservice_move_session_handling_as_part_of_the_interface     #564      +/-   ##
=====================================================================================================
- Coverage                                                              65.45%   65.40%   -0.06%     
=====================================================================================================
  Files                                                                    207      207              
  Lines                                                                  25606    25602       -4     
=====================================================================================================
- Hits                                                                   16760    16744      -16     
- Misses                                                                  7367     7375       +8     
- Partials                                                                1479     1483       +4     
Files Coverage Δ
gateway/blocks_backend.go 42.27% <0.00%> (-0.10%) :arrow_down:
blockservice/blockservice.go 75.72% <37.50%> (-1.34%) :arrow_down:

... and 14 files with indirect coverage changes

codecov[bot] avatar Jan 15 '24 12:01 codecov[bot]