boxo icon indicating copy to clipboard operation
boxo copied to clipboard

coreiface: deprecate DhtAPI in favor of RoutingAPI

Open Jorropo opened this issue 2 years ago • 4 comments

Jorropo avatar Sep 05 '23 17:09 Jorropo

Codecov Report

Merging #461 (9f2683a) into main (574df96) will decrease coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   66.47%   66.44%   -0.04%     
==========================================
  Files         207      207              
  Lines       24681    24681              
==========================================
- Hits        16407    16399       -8     
- Misses       6851     6858       +7     
- Partials     1423     1424       +1     

see 11 files with indirect coverage changes

codecov[bot] avatar Sep 05 '23 17:09 codecov[bot]

@Jorropo why skip changelog here? We're deprecating an API. No we're not removing it or anything but seems reasonable to mention.

aschmahmann avatar Sep 05 '23 18:09 aschmahmann

Good question, the API was already deprecated in Kubo and I had tunnel vision. I'll add changelog here thx.

Jorropo avatar Sep 05 '23 18:09 Jorropo

Triage notes:

  • needs Kubo PR to show we dont remove/deprecate too much
    • converting to draft, as we need to look at this from Kub oside, afaik ipfs routing in Kubo does the same thing as ipfs dht but
      • does not allow for selecting backend, so not possible to run dht-only query without chaing config to be dht-only
      • ipfs dht query is not present in ipfs routing

lidel avatar Sep 25 '23 13:09 lidel