ipfs-pack icon indicating copy to clipboard operation
ipfs-pack copied to clipboard

Published 20 hours ago • verified publisher icon ipfs-shipyard

Add more tests (use sharness)

Open whyrusleeping opened this issue 7 years ago • 4 comments

We should add some solid tests here, a lot of edge cases to test.

  • Test basic creation, serving, verify, repo regen rm and other commands
  • Test different permissions issues (how does pack make fail under bad permissions)
  • Test pack creation from different directories (passing 'dir' parameter for different commands)
  • Test changing files in the pack before and/or during serve
  • Test moving, deleting, changing perms, etc on files before/during serve

cc @chriscool, do you think you would have time to help us out on this?

whyrusleeping avatar Mar 06 '17 18:03 whyrusleeping

@whyrusleeping I will take a look at this next week end.

chriscool avatar Mar 07 '17 07:03 chriscool

@chriscool great! thanks!

Also, lets not do these ones in docker, its really nice to have, but it prevents us from actually testing on OSX (since the docker environment on OSX is actually linux)

whyrusleeping avatar Mar 07 '17 21:03 whyrusleeping

When I run ./test/pack-serve.sh I get "Error: invalid peer address: protocol requires address, none given: ipfs". See pack-serve.txt

chriscool avatar Mar 11 '17 17:03 chriscool

Sharness support and basic tests are available in PR https://github.com/ipfs/ipfs-pack/pull/22

chriscool avatar Mar 11 '17 20:03 chriscool