container-demos icon indicating copy to clipboard operation
container-demos copied to clipboard

WIP: Feat/backend toggle switch for desktop settings

Open Jacekdaa opened this issue 6 years ago • 0 comments

@phoniks commented on Tue Dec 04 2018

Seeking feedback. I'm working on enabling the user to try out the Javascript implementation of IPFS by toggling a switch on the settings page. This PR simply ads a checkbox on the DesktopSettings page. I'm particularly interested in knowing whether having this as a checkbox makes sense. Originally I had in mind, based on the original discussions of this feature, to make this setting a select component, but during coding it became obvious that doing so would add a lot of code for not very much change in user experience. Perhaps in the future, if there are other implementations that can be chosen, it may make sense to do the dropdown, but for now it doesn't seem prudent. But, perhaps since it potentially takes your node offline there should be an intermediate step between flipping the switch and actually shutting down the node and re-spawning. Maybe a quick confirmation alert?

Jacekdaa avatar Aug 24 '19 13:08 Jacekdaa