IGiS icon indicating copy to clipboard operation
IGiS copied to clipboard

RFC: Pull Requests implemented with OrbitDB

Open dirkmc opened this issue 7 years ago • 5 comments

This is a read only implementation of what a pull request with comments may look like, using OrbitDB

screen shot 2018-07-27 at 10 06 00 am screen shot 2018-07-27 at 10 06 15 am screen shot 2018-07-27 at 10 06 25 am

dirkmc avatar Jul 27 '18 14:07 dirkmc

This is so amazing! Great to see this move!

I'm guessing this is still WIP, but I did go through the code quickly, looks good, but in future prs it would be nice to have the refactorings go into separate commits (easier to review / less noise)

magik6k avatar Jul 27 '18 16:07 magik6k

Yes, still work in progress. I wanted to implement a read-only mock to get a better understanding of the challenges involved with using CRDTs. Good point about the refactoring, I will separate that out into different commits in future 👍

dirkmc avatar Jul 27 '18 16:07 dirkmc

The last commit adds a button to the compare screen so that a new PR can be created:

screen shot 2018-07-30 at 3 30 31 pm

New PR form:

screen shot 2018-07-30 at 3 31 21 pm

Submitting the form takes the user to the list of PRs:

screen shot 2018-07-30 at 3 31 33 pm

Clicking on a PR in the list takes the user to the PR page:

screen shot 2018-07-30 at 3 31 44 pm

dirkmc avatar Jul 30 '18 19:07 dirkmc

There's been a bunch of commits in this PR since I gave an update, so here's a short video showing some of the functionality. Basically you can now create a PR and you and other users can comment on it, and everything is synched using OrbitDB: https://youtu.be/3lVBUjRbBd0

dirkmc avatar Aug 13 '18 22:08 dirkmc

Added a super simple mechanism for people to create a user. It shows a form where they can choose username, name and avatar and then it creates an IPFS object with those fields and saves the CID to local storage. This is used as their "authenticated" user. Obviously not secure, it's just for PoC: https://youtu.be/blUgFx1KJfw

dirkmc avatar Aug 14 '18 22:08 dirkmc