examples icon indicating copy to clipboard operation
examples copied to clipboard

add guide to creating your own ipfs transport

Open whyrusleeping opened this issue 9 years ago • 4 comments

cc @diasdavid @lgierth @RichardLitt for review and feedback

whyrusleeping avatar Jul 28 '16 10:07 whyrusleeping

@whyrusleeping I know spell checkers are annoying due to not knowing all of the terminology, but I think adding apostrophes in contractions, and capitalizing 'I' is something that needs to be done, and I don't think it's the reviewer's job to point out things like that. Can you do a pass with your spell checker before asking for feedback?

This is basically the same as asking me to do go fmt before submitted a golang PR, I think.

RichardLitt avatar Jul 28 '16 18:07 RichardLitt

I believe it would help to understand if the blog post was divided into two sections: a) how to plug in the WebSockets transport into libp2p (just reusing the module that is already there and making a dial); b) how to design a transport for libp2p, taking into example how the WebSockets was built

daviddias avatar Aug 01 '16 15:08 daviddias

Is this good to go?

ghost avatar Oct 28 '16 21:10 ghost

No. It needs to be copy edited. I asked @whyrusleeping to go over it again. @whyrusleeping can you help with that? I can split it into two parts after that.

RichardLitt avatar Nov 10 '16 13:11 RichardLitt