crane icon indicating copy to clipboard operation
crane copied to clipboard

Cargo is trying to fetch stuff out of band from `crates.io` after git&patched version was changed to release version.

Open dpc opened this issue 2 years ago • 2 comments

https://github.com/fedimint/fedimint/runs/7830647635?check_suite_focus=true (corresponding PR )

I might be misreading it, but it looks like crane lets cargo run with the previous state from cache, even thought the source of a dependency has changed. Cargo considers it missing, and tries to fetch it, but Nix does not appreciate such an impure conduct.

dpc avatar Aug 15 '22 02:08 dpc

Sounds like the dependency vendoring has failed somehow (and why cargo is trying to fetch the deps directly).

Looks like the PR link above is incorrect, could you provide a link to the faulty commit? I wonder what changed so that vendoring doesn't work

ipetkov avatar Aug 15 '22 15:08 ipetkov

Fixed: https://github.com/fedimint/fedimint/pull/354 , but unfortunately at this point the branch was force pushed with something else that invalidated the previous cache, and rebuilding seems to work just fine.

Sounds like the dependency vendoring has failed somehow

I don't think it failed. It seemed more like crane considered the previous (git version) source as adequate(?) and didn't even attempt to vendor the new version.

Or maybe I'm just confused.

dpc avatar Aug 15 '22 16:08 dpc

I think this might have been an user error as well. My apologies.

dpc avatar Aug 15 '22 23:08 dpc