crane icon indicating copy to clipboard operation
crane copied to clipboard

cargoTarpaulin broken- permission issue

Open ngerstle-cognite opened this issue 3 years ago • 3 comments

https://github.com/ipetkov/crane/pull/49 seems to have broken my use of cargoTarpaulin- reverting the cargoBuildCommand from

cargoBuildCommand = "cargoWithProfile tarpaulin";

to

cargoBuildCommand = "cargo tarpaulin";` 

in lib/cargoTarpaulin.nix avoided a number of permission denied panics:

nix flake check #.x86_64-linux.app-tarpaulin
error: builder for '/nix/store/92x8a0ba5lxbvq0zrgb57dxr7yjm9i7z-app-tarpaulin-0.1.0.drv' failed with exit code 1;
       last 10 log lines:
       >   running: "ar" "s" "/build/source/target/release/build/zstd-sys-49da8651afb28f6d/out/libzstd.a"
       >   exit status: 0
       >   cargo:rustc-link-lib=static=zstd
       >   cargo:rustc-link-search=native=/build/source/target/release/build/zstd-sys-49da8651afb28f6d/out
       >
       >   --- stderr
       >   thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }', /nix/store/igrpi0wmjyxx07v5z2crnk21m6fsrpgk-vendor-cargo-deps/c19b7c6f923b580ac259164a89f2577984ad5ab09ee9d583b888f934adbbe8d0/zstd-sys-2.0.1+zstd.1.5.2/build.rs:184:58
       >   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
       > Jul 26 13:30:53.889 ERROR cargo_tarpaulin: Cargo failed to run! Error: cargo run failed
       > Error: "Cargo failed to run! Error: cargo run failed"

ngerstle-cognite avatar Jul 26 '22 13:07 ngerstle-cognite

Hmm thanks for the report @ngerstle-cognite! Do you have a minimal repro of the error?

I don't mind reverting the tarpaulin change, but I'm really curious why setting a --release flag would make tarpaulin fail that way

ipetkov avatar Jul 27 '22 00:07 ipetkov

Hmm thanks for the report @ngerstle-cognite! Do you have a minimal repro of the error?

I don't mind reverting the tarpaulin change, but I'm really curious why setting a --release flag would make tarpaulin fail that way

I'll see if I can put something together.

ngerstle-cognite avatar Jul 28 '22 09:07 ngerstle-cognite

@ngerstle-cognite were you able to get a minimal repro of this?

I'm probably going to tag another release sometime this week, but we can always revert the tarpaulin change later as well, so no rush

ipetkov avatar Aug 07 '22 18:08 ipetkov

Closing due to inactivity and because I haven't been able to reproduce this. Feel free to reopen if you have more info!

ipetkov avatar Sep 20 '22 01:09 ipetkov