Ivan Petkov

Results 124 comments of Ivan Petkov

Hmm that's disappointing, do you have a flake which reproduces the issue I can peek at?

Running `wasm-pack` through `strace` showed `statx(AT_FDCWD, "/homeless-shelter", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7fffffffa600) = -1 ENOENT (No such file or directory)` so it seems the case that `wasm-pack` cannot handle the situation where...

Hi @j-baker thanks for the report! As of today, [downloading](https://github.com/ipetkov/crane/blob/33dbb6a8342e1cf6252c8976d02ff8a7632aa071/lib/downloadCargoPackage.nix#L13-L17) and [unpacking](https://github.com/ipetkov/crane/blob/33dbb6a8342e1cf6252c8976d02ff8a7632aa071/lib/downloadCargoPackage.nix#L19-L23) crates happens in two derivations which is undoubtedly contributing to the increase in total derivation count. Sadly we...

Hi @shimunn thanks for the contribution! I see this is marked as draft so I'll hold off on reviewing it, but let me know if you'd like any particular feedback!

I'm not entirely sure why that happens, maybe it's the default `--output-path $out` argument that we set? cc @figsoda in case you have more context around this?

Hi @pingiun thanks for the report and the test case! Definitely looks like a bug with `toml_edit`, would you mind opening an issue upstream for it? Happy to get it...

Oh hmm we're a minor version behind, let me see if bumping it will fix it first

Same issue with `toml_edit` 0.22.6: https://github.com/ipetkov/crane/commit/50c9f5f41f67469c7e3e10fb3a9c5ac086150e8b Here's the branch: https://github.com/ipetkov/crane/compare/toml_edit

Looks like there is a report for it here: https://github.com/toml-rs/toml/issues/691

Looks like this will be fixed with https://github.com/ipetkov/crane/pull/583