Ivan Petkov

Results 124 comments of Ivan Petkov

Thanks for the report @newAM ! I believe #126 should address this issue if you are interested in testing it out locally

@rvolosatovs > I'd love to, if fact I looked into doing that while working on this, but was not clear how to proceed, so I did not. The test suite...

This looks great, thanks again @rvolosatovs! I've pushed some very minor fixes which weren't even worth mentioning here, will merge as soon as CI passes!

@tomhoule could you provide a flake.nix with which I can reproduce the issue? (bonus points if it's a minimal setup)

Wonder if this is an issue with `cargo` itself. Looks like `cargo vendor` does not (yet?) work with dependencies which use workspace inheritance: https://github.com/rust-lang/cargo/issues/11192 We don't use `cargo vendor` _directly_,...

Thanks for the report @TheNeikos! Yes `cleanCargoSource` is fairly aggressive in what it filters out as a nice default to avoid unnecessary rebuilds for most projects. [It is possible to...

Definitely an interesting suggestion! The hard part of supporting this is the fact that (IIRC) `-Zminimal-versions` requires cargo do to a fresh resolution. Vendoring crates in a sandbox friendly way...

> Would running `cargo update -Zminimal-versions` first, then capturing `Cargo.lock` then and following normal `crane` flow from there be an option / help with anything? Yes I think that would...

> Why exactly? For caching reasons? For network sandboxing reasons. By default cargo will fetch the crates.io index over the network and then use that for resolving which crate versions...

Hi @rbozan thanks for the report! Just a quick question, does the `Cargo.toml` file depend on a private git repository? Or are you trying to replace a dependency with a...