Ivan Petkov

Results 124 comments of Ivan Petkov

Hi @iwinux thanks for the report! Currently we copy over the `Cargo.lock` completely untouched when creating the dummified sources (to build only dependency crates). When a workspace package's version changes,...

Thanks for opening this @asymmetric ! > Creating as a draft to gauge interest before sinking more time into this :) Yes I'd be happy to include this 😃

> As I understand it the issue is that when building multiple packages simultaneously, cargo will unify the features of dependencies so that it doesn't have to build the dependencies...

@dpc is the difference mostly to pass in `--workspace`? (I'm ignoring the part on running nextest atm) Originally the default cargo args would pass that in, but I wanted `buildPackage`...

Thanks for reporting this @iliana! It was always the intention to maintain the same project structure (including any targets) between the deps-only and final builds (so that setting `--bin whatever`...

> Crane currently triggers a full rebuild of all dependencies, even when only a single dependency is updated. This is an unfortunate consequence of the fact that changing `Cargo.lock` will...

Hi @sellout thanks for the report! Let me ask a bit more concretely: what potential advantages would you be interested in seeing from`buildWorkspace` which would be impossible with `buildPackage`? (keeping...

Thanks for the PR @nrabulinski! Like @dpc mentioned we switched from `toml` to `toml_edit` to accommodate things like `document-features`. It's pretty unfortunate to be stuck waiting on a fix for...

Thanks again for the PR @nrabulinski ! It looks like https://github.com/ipetkov/crane/pull/583 has a workaround for this by ignoring (stripping) all comments when doing workspace inheritance until https://github.com/toml-rs/toml/issues/691 is fixed. Please...

Hi @ondt thanks for the report! I unfortunately do not have access to multiple registries that I can test with so I may need to rely on you to help...