DeepFaceLab icon indicating copy to clipboard operation
DeepFaceLab copied to clipboard

New feature: Add QButton to apply the baked mask as an Xseg mask

Open CopaceticMeatbag opened this issue 2 years ago • 1 comments

Issue

Using iperov's awesome RTM v2 faceset my masks are 99% great in a few minutes with just a tiny bit of fixing needed. I need to fully define the xseg mask in these instances, even though 99% of it is already perfectly accurate. It would save a ton of time if I could convert the baked mask to an xseg poly, then I could quickly refine the 1% of the poly that needs a little realigning.

Suggestion

I imagine we just need to add an arbitrary number of points along the edges of the baked mask as a new poly, then reuse some of the code from canvas_finalize to save those as a mask, maybe like dflimg.set_seg_ie_polys( new_ie_poly_from_baked ), then refresh the image data to overlay the new xseg mask ready for adjusting.

I'm looking into this myself now, but I rarely use Python; hopefully if I'm trying to dig a hole underwater someone more versed in Python than me can chime in and save me some time and tell me why this won't work haha.

CopaceticMeatbag avatar Feb 11 '23 10:02 CopaceticMeatbag

This is a really great idea. A feature or tool like this would be great! There are so many times I would do the generic xseg apply (having replaced my xseg model with a much deeper trained one) and at the end for me about 90% of the frames are good and just a few need touch up.

Granted another feature that would be awesome is a quicker way to scroll through the images, say a scroll bar so that you can fast scroll over to a part where you know problems will exist.

pmajor74 avatar Aug 23 '23 19:08 pmajor74