Inti Pelupessy
Inti Pelupessy
how does it do with the tests?
its very hard to review with the zillion formatting changes... [its not a good sign when github refuses to load the diff]
can you give an example of that? what happens if you keep the old overload available?
does the ror still work after this? maybe is also good to take stock of all the implications that this change has (issue?): - old simulation scipts - documentation -...
quantities has a as_unit and a to_unit - they are slightly different...don't know why.. (i prefer the name to_unit, don't know about implementation yet) also - there are a bunch...
hmm, not sure this goes ok....
btw ignore the review, these are just comments
would it work if ```1000*m``` resolves to a quantity and m*1000 to a unit?
did you see the comment on line 87 of core? (__rmul__)
also the check for a numerical factor of exactly one should then maybe go to ```__mul__``` or do something with factor_unit, but that is tricky...