github-as-code

github-as-code copied to clipboard

Write now, terraform will happily propose creating collaborator relationship with a team, for example, where in fact it would fail on apply.

galargh

It's not enough to make plan/comment required. Other plan/* checks should be required too.

1

We could accomplish that by having a catch-all check at the end maybe? plan/comment is not enough because skipped status doesn't block merging. That's really counter-intuitive.

galargh

https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment

galargh

Automate side-tasks required for repo archiving

1

When a repo gets archived, we want to be able to perform additional tasks like adding a header to the readme for example. GitHub Management has creds to do it....

galargh

https://docs.github.com/en/actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-amazon-web-services Might be obsolete if we implement https://github.com/protocol/github-mgmt-template/issues/76

galargh

GitHub Management should be able to manage labels in repos. This was requested here - https://github.com/ipfs/github-mgmt/issues/74 - for example

galargh

Otherwise, state refresh can fail if it tries to refresh a resource that no longer exists (this is true at least for repositories that were moved to different orgs).

galargh

I know we have talked about different ideas to improve the json structure. Another idea may be to have a quick tool that one can run and answer "after these...

galargh

Document what to do if the upgrade contains terraform provider upgrades

1

One has to manually run the sync workflow against the upgrade branch then.

galargh

We should notify CODEOWNERS about failing Apply. Alternatively, we could notify the person who merged the PR that initiated the Apply.

galargh