github-as-code icon indicating copy to clipboard operation
github-as-code copied to clipboard

Support a diverse set of owners while limiting blast radius

Open BigLep opened this issue 1 year ago • 1 comments

Problem

Github orgs with a diverse set of projects and stakeholders (e.g., filecoin-project) have inherent risks by using github-mgmt/github-as-code. They ideally want a diverse-enough set of representatives with push access to filecoin-project/github-mgmt, but anyone who has push access can effectively make large permissions changes on projects that are unrelated to their own. It would be ideal for example if lotus maintainers could approve permissions changes to their repos or teams but not to other groups' repos and teams.

Ideas

  1. If instead of having one large .yaml file there were multiple YAML files (one per repo or team), codeowners could be used and branch protection to require PR approval from a codeowner.
  2. If gihtub-mgmt CI checks were intelligent to identify which resource or repo was modified, they could wait to pass until someone with write access to that repo or team approved the PR.

BigLep avatar Jun 06 '24 21:06 BigLep

This issue was referenced in https://github.com/filecoin-project/community/discussions/710

BigLep avatar Jul 20 '24 02:07 BigLep