ovs icon indicating copy to clipboard operation
ovs copied to clipboard

Update command-line usage text

Open ffoulkes opened this issue 3 years ago • 2 comments

  • Edited usage text for command-line utilities and daemons. Made name column 30 characters wide.
  • Refactored ovs-vctl usage() function into several smaller functions.
  • Added text for P4 commands.

ffoulkes avatar Aug 16 '22 20:08 ffoulkes

Can you elaborate why all the output strings are made longer with extra space characters in this PR?

5abeel avatar Aug 19 '22 18:08 5abeel

Can you elaborate why all the output strings are made longer with extra space characters in this PR?

The first column was widened from 27 to 30 characters. I assume this was because of the number of instances where the text in the first column exceeded its size, resulting in a choppy right-hand column.

If you look at the side-by-side comparisons in ovsdb-tool and ovs-dptl, I think you'll see that the new text is a little more readable than the old text.

There were also a couple of places where a two-space indent was added. I believe this was for greater consistency among the various tools.

I'm extracting other people's edits from P4-OVS and reapplying them in a separate branch. I don't necessarily know the reasons why they made them. :)

ffoulkes avatar Aug 19 '22 20:08 ffoulkes

PR abandoned

ffoulkes avatar Dec 06 '22 15:12 ffoulkes