ipdk icon indicating copy to clipboard operation
ipdk copied to clipboard

Refactor makefile, add ubuntu1804 and fix label bug

Open stolsma opened this issue 3 years ago • 3 comments

Add Ubuntu 18.04 as checked base image. Refactor build, push and export steps Fix label bug where label data with comma is truncated

Signed-off-by: stolsma [email protected]

stolsma avatar Feb 23 '22 11:02 stolsma

Ubuntu 18.04 Bionic Beaver will be supported until April of 2023. Not sure we really want to add support for it here. What do you think @stolsma?

mestery avatar Feb 23 '22 14:02 mestery

If we don't do support we also have to remove all the 18.04 specific build scripting IMHO. I don't think we are that far to decide on that, so that's why I added it to the CI build step. Then we at least will know when 18.04 doesn't work.... Also its only one reference to add at the moment so no big deal to add😉

stolsma avatar Feb 23 '22 15:02 stolsma

Btw it should be ready for review after this last running check (I removed some debugging lines...)

stolsma avatar Feb 23 '22 15:02 stolsma