Plans for x86 arch support?

[ithamsteri]

Hi,

Can I use ply for i586 architecture? When I try to compile ply I see the follow error:

| make  all-recursive
| make[1]: Entering directory `/local/workspace/ply/2.1.0-r2'
| Making all in include
| make[2]: Entering directory `/local/workspace/ply/2.1.0-r2/include'
| make[2]: Nothing to be done for `all'.
| make[2]: Leaving directory `/local/workspace/ply/2.1.0-r2/include'
| Making all in src
| make[2]: Entering directory `/local/workspace/ply/2.1.0-r2/src'
| Making all in libply
| make[3]: Entering directory `/local/workspace/ply/2.1.0-r2/src/libply'
| make  all-am
| make[4]: Entering directory `/local/workspace/ply/2.1.0-r2/src/libply'
| make[4]: *** No rule to make target `arch/i586.c', needed by `arch/libply_la-i586.lo'.  Stop.
| make[4]: Leaving directory `/local/workspace/ply/2.1.0-r2/src/libply'
| make[3]: *** [all] Error 2
| make[3]: Leaving directory `/local/workspace/ply/2.1.0-r2/src/libply'
| make[2]: *** [all-recursive] Error 1
| make[2]: Leaving directory `/local/workspace/ply/2.1.0-r2/src'
| make[1]: *** [all-recursive] Error 1
| make[1]: Leaving directory `/local/workspace/ply/2.1.0-r2'
| make: *** [all] Error 2
| autoreconf: make failed with exit status: 2

[wkz]

Short answer: No

That said, if you want to add support for it, it would probably be quite easy. All you need to do is to create the missing file (probably starting from x86_64.c) and modify the definitions to match the x86 ABI.

[ithamsteri]

Thanks for the answer.

At first glance it seems that adding support for x86 is not difficult. I have difficulty passing arguments, as x86 passes arguments not through registers, but through the stack (the arch_register_argument function). In this case, the function should always return NULL for x86?

[wkz]

Ouch! Well in that case it is actually a bit more work.

The some of the code in kprobe_arg_rewrite will have to be moved to the arch-specific code. Then the x86 variant can generate the code that will fish out the arguments from the stack.