kubectl-trace icon indicating copy to clipboard operation
kubectl-trace copied to clipboard

refactor: only define usr-host volume if to be mounted by a container

Open consideRatio opened this issue 3 years ago • 1 comments

This PR makes a usr-host Volume be conditionally added, side by side with the conditionally added VolumeMount entry referencing it.

I think the current behavior of declaring a volume that isn't mounted will be fully functional, and this fix just makes it easier to understand the workload by not including an unused volume.

consideRatio avatar May 29 '22 07:05 consideRatio

It makes sense @consideRatio this was a mistake in the first instance, thanks for fixing it!

fntlnz avatar Jun 06 '22 12:06 fntlnz

I rebased this PR on the current master branch. I think that should resolve the test failures previously observed where ubuntu-16.04 still was used.

consideRatio avatar Oct 08 '22 14:10 consideRatio

Thank you @consideRatio !

fntlnz avatar Jan 24 '23 13:01 fntlnz