iov-core icon indicating copy to clipboard operation
iov-core copied to clipboard

Add tests to update BNS cash configuration

Open webmaster128 opened this issue 6 years ago • 6 comments

Each module can have a Configuration object and a transaction type to update this. For cash this is

Looks like there is only one configuration that can be updated at the moment

webmaster128 avatar Jun 06 '19 15:06 webmaster128

@webmaster128 Is it definitely just unit tests for this issue or do we need to sort out encoding/decoding of a transaction?

willclarktech avatar Jun 19 '19 15:06 willclarktech

@willclarktech sorry, unittests -> tests. There should be a test showing that Configuration can be updated. This requires encoding/decoding of the ConfigurationMsg and the new configuration object.

webmaster128 avatar Jun 24 '19 07:06 webmaster128

Waiting for app.Tx to be updated, probably in Weave 0.17.1.

willclarktech avatar Jun 25 '19 11:06 willclarktech

@webmaster128 What's the current status of this issue. Should we add it to 1.0?

willclarktech avatar Sep 24 '19 14:09 willclarktech

@willclarktech I'd not consider it a blocker for 1.0.0, but as far as I can see it is ready for development. I moved it to position 1 in the backlog

webmaster128 avatar Sep 24 '19 14:09 webmaster128

Blocked by https://github.com/iov-one/weave/issues/815 which is scheduled for post-MVP.

willclarktech avatar Sep 25 '19 11:09 willclarktech