iotivity-lite icon indicating copy to clipboard operation
iotivity-lite copied to clipboard

add Push Notification support (CR2483)

Open joochlee opened this issue 2 years ago • 9 comments

Push Notification support for iotivity-lite (CR2483)

joochlee avatar May 23 '22 17:05 joochlee

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar May 23 '22 17:05 github-actions[bot]

I have read the CLA Document and I hereby sign the CLA

joochlee avatar May 24 '22 02:05 joochlee

Would it be possible to create an example application in apps directory? This is an extensive feature and I don't see any documentation or example, so I'm not sure people will know how to use it.

Also, I've added SonarCloud scan for this repo - it does some stylistic and linting checks, though I'm not sure the job will start for a fork. We will see when you rebase, I'd like the keep the amount of new issues reported by SC to zero.

I don't see coding problems in the pushed commits, but I haven't checked adherence to the specification... I guess there is nobody else to do it, eh?

Danielius1922 avatar Jul 18 '22 15:07 Danielius1922

Would it be possible to create an example application in apps directory? This is an extensive feature and I don't see any documentation or example, so I'm not sure people will know how to use it.

=> Sure, I'll do it. Where do you want me to add documentation? Add to existing readme.md, or create separate one ?

Also, I've added SonarCloud scan for this repo - it does some stylistic and linting checks, though I'm not sure the job will start for a fork. We will see when you rebase, I'd like the keep the amount of new issues reported by SC to zero.

I don't see coding problems in the pushed commits, but I haven't checked adherence to the specification... I guess there is nobody else to do it, eh?

=> I created CR3530 - Test case for Bug2483 Bug2658 and 2 CTT test case codes. The 2 CTT test case codes have already been merged to ctt-files repo. Comarch reviewed and merged them.

joochlee avatar Jul 19 '22 01:07 joochlee

=> Sure, I'll do it. Where do you want me to add documentation? Add to existing readme.md, or create separate one ?

I don't want the main readme.md to be too long, so not there. Are you creating a demo app? If so I see that there is an .md file in the apps folder, where the demo application are described. If you want to create just documentation then I would create a new folder 'doc' and create a new .md file there which documents the feature.

Danielius1922 avatar Jul 19 '22 15:07 Danielius1922

=> Sure, I'll do it. Where do you want me to add documentation? Add to existing readme.md, or create separate one ?

I don't want the main readme.md to be too long, so not there. Are you creating a demo app? If so I see that there is an .md file in the apps folder, where the demo application are described. If you want to create just documentation then I would create a new folder 'doc' and create a new .md file there which documents the feature.

It looks like that apps/Readme.md is not a good place to describe additional feature such as push notification. So I think creating new doc folder is better idea.

joochlee avatar Jul 20 '22 06:07 joochlee

It looks like that apps/Readme.md is not a good place to describe additional feature such as push notification. So I think creating new doc folder is better idea.

Another alternative would be to put it in https://github.com/iotivity/iotivity.github.io . I think both options are good, pick the one you like.

Danielius1922 avatar Jul 27 '22 10:07 Danielius1922

It looks like that apps/Readme.md is not a good place to describe additional feature such as push notification. So I think creating new doc folder is better idea.

Another alternative would be to put it in https://github.com/iotivity/iotivity.github.io . I think both options are good, pick the one you like.

Hi Daniel, I pushed new commit including examples & documentations. If you think that it looks ok, I'll rebase final commit and push it again.

joochlee avatar Aug 10 '22 09:08 joochlee

~format

Danielius1922 avatar Aug 26 '22 07:08 Danielius1922

Closed since the other PR with these commits squashed was merged (github won't delete this PR, so you can still find it if you need to see what work was done).

Danielius1922 avatar Sep 26 '22 13:09 Danielius1922