iotex-core icon indicating copy to clipboard operation
iotex-core copied to clipboard

[action] pass tx type to ToEthTx() method

Open dustinxie opened this issue 10 months ago • 1 comments

Description

We are going to implement EIP-1559, which introduced a new DynamicFeeTx type. Together with the existing LegacyTx and AccessListTx (also going to be enabled soon), we now have 3 types of Ethereum txs that native action can possibly convert to. So need to pass in the Ether tx type to ToEthTx() method.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [x] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

dustinxie avatar Apr 23 '24 00:04 dustinxie